-
Notifications
You must be signed in to change notification settings - Fork 284
Merge recv
/send
into read
/write
.
#240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,6 +38,8 @@ | |
(enum u16 | ||
;;; No error occurred. System call completed successfully. | ||
$success | ||
;;; End of stream was reached successfully. | ||
$success_eos | ||
;;; Argument list too long. | ||
$2big | ||
;;; Permission denied. | ||
|
@@ -201,7 +203,7 @@ | |
;;; If `path_open` is set, includes the right to invoke | ||
;;; `path_open` with `fdflags::dsync`. | ||
$fd_datasync | ||
;;; The right to invoke `fd_read` and `sock_recv`. | ||
;;; The right to invoke `fd_read`. | ||
;; | ||
;;; If `rights::fd_seek` is set, includes the right to invoke `fd_pread`. | ||
$fd_read | ||
|
@@ -218,7 +220,7 @@ | |
;;; remains unaltered (i.e., `whence::cur` with offset zero), or to | ||
;;; invoke `fd_tell`. | ||
$fd_tell | ||
;;; The right to invoke `fd_write` and `sock_send`. | ||
;;; The right to invoke `fd_write`. | ||
;;; If `rights::fd_seek` is set, includes the right to invoke `fd_pwrite`. | ||
$fd_write | ||
;;; The right to invoke `fd_advise`. | ||
|
@@ -271,8 +273,10 @@ | |
;;; If `rights::fd_read` is set, includes the right to invoke `poll_oneoff` to subscribe to `eventtype::fd_read`. | ||
;;; If `rights::fd_write` is set, includes the right to invoke `poll_oneoff` to subscribe to `eventtype::fd_write`. | ||
$poll_fd_readwrite | ||
;;; The right to invoke `sock_shutdown`. | ||
$sock_shutdown | ||
;;; The right to invoke `fd_shutdown`. | ||
$fd_shutdown | ||
;;; The output supports line-oriented terminal output. | ||
$fd_line_oriented_terminal | ||
) | ||
) | ||
|
||
|
@@ -408,8 +412,6 @@ | |
;;; File descriptor attributes. | ||
(typename $fdstat | ||
(struct | ||
;;; File type. | ||
(field $fs_filetype $filetype) | ||
;;; File descriptor flags. | ||
(field $fs_flags $fdflags) | ||
;;; Rights that apply to this file descriptor. | ||
|
@@ -638,25 +640,23 @@ | |
;;; Exit code generated by a process when exiting. | ||
(typename $exitcode u32) | ||
|
||
;;; Flags provided to `sock_recv`. | ||
;;; Flags provided to `fd_read`. | ||
(typename $riflags | ||
(flags u16 | ||
;;; Returns the message without removing it from the socket's receive queue. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this say something like |
||
$recv_peek | ||
;;; On byte-stream sockets, block until the full amount of data can be returned. | ||
$recv_waitall | ||
) | ||
) | ||
;;; | ||
;;; Note: This is similar to the `MSG_PEEK` flag in `recv` in POSIX. | ||
$read_peek | ||
|
||
;;; Flags returned by `sock_recv`. | ||
(typename $roflags | ||
(flags u16 | ||
;;; Returned by `sock_recv`: Message data has been truncated. | ||
$recv_data_truncated | ||
;;; On bytestream sockets, block until the full amount of data can be returned, | ||
;;; unless an error or disconnect occurs. | ||
;;; | ||
;;; Note: This is similar to the `MSG_WAITALL` flag in `recv` in POSIX. | ||
$read_waitall | ||
) | ||
) | ||
|
||
;;; Flags provided to `sock_send`. As there are currently no flags | ||
;;; Flags provided to `fd_write`. As there are currently no flags | ||
;;; defined, it must be set to zero. | ||
(typename $siflags u16) | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a little strange to call this a
right
.