Skip to content

Commit d0e92fe

Browse files
authored
Pin v8 10.8.104 (#5112)
More recent version of V8 include a change from `dataref` to `structref` that prevent WasmGC modules produced by the fuzzer from validating. Use the last compatible v8 version if it is in the path until we can update Binaryen to be compatible with newer v8.
1 parent d9ce340 commit d0e92fe

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

scripts/test/shared.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,10 @@ def is_exe(fpath):
201201
which('g++') or which('clang++'))
202202
NODEJS = os.getenv('NODE', which('node') or which('nodejs'))
203203
MOZJS = which('mozjs') or which('spidermonkey')
204-
V8 = which('v8') or which('d8')
204+
205+
# TODO: Remove the specific v8 version once we implement structref and can run
206+
# on recent v8.
207+
V8 = which('v8-10.8.104') or which('v8') or which('d8')
205208

206209
BINARYEN_INSTALL_DIR = os.path.dirname(options.binaryen_bin)
207210
WASM_OPT = [os.path.join(options.binaryen_bin, 'wasm-opt')]

0 commit comments

Comments
 (0)