Skip to content

Pin v8 10.8.104 #5112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Pin v8 10.8.104 #5112

merged 1 commit into from
Oct 5, 2022

Conversation

tlively
Copy link
Member

@tlively tlively commented Oct 5, 2022

More recent version of V8 include a change from dataref to structref that
prevent WasmGC modules produced by the fuzzer from validating. Use the last
compatible v8 version if it is in the path until we can update Binaryen to be
compatible with newer v8.

@tlively tlively requested a review from kripken October 5, 2022 00:56
@tlively
Copy link
Member Author

tlively commented Oct 5, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

Base automatically changed from fix-type-counts to main October 5, 2022 02:51
More recent version of V8 include a change from `dataref` to `structref` that
prevent WasmGC modules produced by the fuzzer from validating. Use the last
compatible v8 version if it is in the path until we can update Binaryen to be
compatible with newer v8.
@tlively tlively merged commit d0e92fe into main Oct 5, 2022
@tlively tlively deleted the pin-v8-10.8.104 branch October 5, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants