Patches for wasm2asmjs

[krisselden]

Sanitize ':' in names as well as '-'.

Just emit a call to abort when visiting host ops instead of aborting.

[kripken]

Thanks!

Can you add a test for these? You can add a X.wast and X.2asm.js (the expected output) in test/.

[krisselden]

@kripken so name can have more symbols than just '-' or ':' I was motivated because rust was emitting names with ':' but should I sanitize all of these?

let symbol = ['+''-''*''/''\\''^''~''=''<''>''!''?''@''#''$''%''&''|'':''`''.''\'']
let name = '$' (letter | digit | '_' | symbol)+

[kripken]

Yeah, in general, anything not valid as JS should be sanitized. We should also eventually add a conflict checking system, so two things don't get sanitized to the same output.

[froydnj]

@krisselden Do you have plans to finish this up?

[krisselden]

@froydnj this was superseded by

#1340 which handled grow_memory and export memory
#1433 which handled name mangling