Add i32x4.dot_i16x8_s #2420
Merged
Add i32x4.dot_i16x8_s #2420
+845
−709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This experimental instruction is specified in WebAssembly/simd#127 and is being implemented to enable further investigation of its performance impact.
aheejin
approved these changes
Nov 4, 2019
| case DotSVecI16x8ToVecI32x4: | ||
| o << int8_t(BinaryConsts::SIMDPrefix) | ||
| << U32LEB(BinaryConsts::I32x4DotSVecI16x8); | ||
| break; |
There was a problem hiding this comment.
It's not particularly about thie PR but Just curious, is there a reason we have different names for Op and BinaryConsts, such as ExtractLaneSVecI18x16 vs. I8x16ExtractLaneS?
There was a problem hiding this comment.
The BinaryConsts exactly mirror the underlying instruction naming with . and _ removed and the name CamelCased, but the Binaryen Op names are shuffled around to put the operation first and the relevant types later. This name change is meant to increase clarity by emphasizing the operation over the types, but it can also make the types clearer in conversion ops by inserting To into the op name, as in DotSVecI16x8ToVecI32x4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This experimental instruction is specified in
WebAssembly/simd#127 and is being implemented
to enable further investigation of its performance impact.