Allow subtypes in tuple operations #2700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some optimizations may replace tuple elements with simpler values, and those simpler values may be a subtype of the original value. Tuple operations should continue to validate without being refinalized in these cases.
|
This fixes a bug found by the fuzzer in the coalesce-locals pass, but the reduced test case is still rather complex and I don't quite grok how coalesce-locals works, so I don't have a simple test case. |
aheejin
approved these changes
Mar 18, 2020
src/wasm/wasm-validator.cpp
Outdated
| @@ -1914,7 +1914,7 @@ void FunctionValidator::visitTupleMake(TupleMake* curr) { | |||
| } | |||
| types.push_back(op->type); | |||
| } | |||
| shouldBeTrue(Type(types) == curr->type, | |||
| shouldBeTrue(Type::isSubType(Type(types), curr->type), | |||
There was a problem hiding this comment.
We have shouldBeSubType (and shouldBeSubTypeOrFirstIsUnreachable too as a counterpart of shouldBeEqualOrFirstIsUnreachable, even though this is not necessary here). The same for below.
|
This seems to have broken CI on master, e.g. https://api.travis-ci.org/v3/job/666072048/log.txt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some optimizations may replace tuple elements with simpler values, and
those simpler values may be a subtype of the original value. Tuple
operations should continue to validate without being refinalized in
these cases.