Make pops valid in tests #3282
Merged
Make pops valid in tests #3282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two tests had pops in invalid locations; pops are valid only after `catch`. This fixes those invalid wasm files. This leaves only one test file with invalid pops: https://github.com/WebAssembly/binaryen/blob/master/test/passes/Os_print-stack-ir_all-features.wast But I'm not sure if we can remove this now, because this tests pops for different types of values than `exnref`. I guess we can fix it after we implement the new spec for EH, which removes `exnref` and there `catch` can extract other types of values.
aheejin
commented
Oct 23, 2020
| @@ -1273,7 +1273,6 @@ | |||
| (try | |||
| (do | |||
| ;; Expressions that can throw should NOT be taken out of 'try' scope. | |||
| (local.set $exn (pop exnref)) | |||
There was a problem hiding this comment.
I'm not sure why we had this line here; I think this was a copy-paste error.
tlively
approved these changes
Oct 23, 2020
kripken
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two tests had pops in invalid locations; pops are valid only after
catch. This fixes those invalid wasm files.This removes pops from Os_print-stack-ir_all-features.wast too.
Fixes #3213 and #3283.