Prototype prefetch instructions #3467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As proposed in WebAssembly/simd#352, using the opcodes used in the LLVM and V8 implementations.
kripken
approved these changes
Jan 6, 2021
src/ir/cost.h
Outdated
| @@ -537,6 +537,7 @@ struct CostAnalyzer : public OverriddenVisitor<CostAnalyzer, Index> { | |||
| Index visitSIMDShuffle(SIMDShuffle* curr) { | |||
| return 1 + visit(curr->left) + visit(curr->right); | |||
| } | |||
| Index visitPrefetch(Prefetch* curr) { return 1 + visit(curr->ptr); } | |||
There was a problem hiding this comment.
I doubt it matters, but maybe this could be 0 instead of 1, as it is meant to speed up later things?
src/wasm/wasm-binary.cpp
Outdated
| default: | ||
| return false; | ||
| } | ||
| auto* curr = allocator.alloc<Prefetch>(); |
There was a problem hiding this comment.
I think it's better to use builder.makePrefetch, that is, to leave the direct allocation to the Builder as much as possible, both here an in the s-parser code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in WebAssembly/simd#352, using the opcodes
used in the LLVM and V8 implementations.