-
Notifications
You must be signed in to change notification settings - Fork 794
Debug info handling for new EH try-catch #3496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
84a34aa
4990843
af57d4e
a211268
c1cc754
3446714
4ffc993
40276eb
3cfaf96
a9d679d
8b11e5f
2797834
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2837,8 +2837,9 @@ BinaryConsts::ASTNodes WasmBinaryBuilder::readExpression(Expression*& curr) { | |
startPos - codeSectionLocation; | ||
} | ||
break; | ||
case BinaryConsts::Catch: | ||
case BinaryConsts::CatchAll: { | ||
case BinaryConsts::Catch: { | ||
// TODO: add CatchAll, but the value of the constant is identical to Else | ||
// case BinaryConsts::CatchAll: { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we can add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, yeah, a stack seems unavoidable. Looks like we already have a control flow stack here, luckily, which I was able to use, PTAL. |
||
curr = nullptr; | ||
if (DWARF && currFunction) { | ||
assert(!controlFlowStack.empty()); | ||
|
Uh oh!
There was an error while loading. Please reload this page.