Add support for relaxed-simd instructions #4320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds relaxed-simd instructions based on the current status of the proposal https://github.com/WebAssembly/relaxed-simd/blob/main/proposals/relaxed-simd/Overview.md. Binary opcodes are based on what is listed in https://github.com/WebAssembly/relaxed-simd/blob/main/proposals/relaxed-simd/Overview.md#binary-format. Text names are not fixed yet, and some sort sort of names that maps to the non-relaxed versions are chosen for this prototype. Support for these instructions have been added to LLVM via builtins, adding support here will allow Emscripten to successfully compile files that use those builtins. Interpreter support has also been added, and they delegate to the non-relaxed versions of the instructions.
MaxGraey
reviewed
Nov 11, 2021
MaxGraey
reviewed
Nov 12, 2021
MaxGraey
reviewed
Nov 12, 2021
kripken
reviewed
Nov 13, 2021
src/wasm-interpreter.h
Outdated
| return c.bitselectV128(a, b); | ||
|
|
||
| case RelaxedFmaVecF32x4: | ||
| return a.addF32x4(b.mulF32x4(c)); |
There was a problem hiding this comment.
As you added fma() methods to Literal, I was expecting to see them used here?
There was a problem hiding this comment.
(This was resolved, but I still don't understand the code in its current form?)
There was a problem hiding this comment.
fma() methods on Literal work on a single lane, in the latest commit i changed this to use a.relaxedFma32x4(b, c), which calls those fma() methods.
MaxGraey
reviewed
Nov 13, 2021
MaxGraey
reviewed
Nov 13, 2021
MaxGraey
reviewed
Nov 13, 2021
MaxGraey
reviewed
Nov 13, 2021
kripken
approved these changes
Nov 15, 2021
tlively
approved these changes
Nov 15, 2021
Thanks! Squash and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds relaxed-simd instructions based on the current status of the
proposal
https://github.com/WebAssembly/relaxed-simd/blob/main/proposals/relaxed-simd/Overview.md.
Binary opcodes are based on what is listed in
https://github.com/WebAssembly/relaxed-simd/blob/main/proposals/relaxed-simd/Overview.md#binary-format.
Text names are not fixed yet, and some sort sort of names that maps to
the non-relaxed versions are chosen for this prototype.
Support for these instructions have been added to LLVM via builtins,
adding support here will allow Emscripten to successfully compile files
that use those builtins.
Interpreter support has also been added, and they delegate to the
non-relaxed versions of the instructions.