Make i31ref and dataref nullable
#4843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
|
@askeska-google has requested that we merge this after merging a solution for #4824. |
kripken
approved these changes
Jul 29, 2022
CHANGELOG.md
Outdated
| @@ -17,6 +17,7 @@ Current Trunk | |||
| - Change constant values of some reference types in the C and JS APIs. This is | |||
| only observable if you hardcode specific values instead of calling the | |||
| relevant methods (like `BinaryenTypeDataref()`). (#4755) | |||
| - `i31ref` and `dataref` are now nullable. (#4843) | |||
There was a problem hiding this comment.
Maybe add that this follows a spec change? (otherwise it seems like maybe it's some decision we made)
Match the latest version of the GC spec. This change does not depend on V8 changing its interpretation of the shorthands because we are still temporarily not emitting the binary shorthands, but all Binaryen users will have to update their interpretations along with this change if they use the text or binary shorthands.
tlively
force-pushed
the
switch-nullability
branch
from
9c742d1 to
4ad58b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match the latest version of the GC spec. This change does not depend on V8
changing its interpretation of the shorthands because we are still temporarily
not emitting the binary shorthands, but all Binaryen users will have to update
their interpretations along with this change if they use the text or binary
shorthands.