Add a type annotation to return_call_ref #5068
Conversation
The GC spec has been updated to have heap type annotations on call_ref and return_call_ref. To avoid breaking users, we will have a graceful, multi-step upgrade to the annotated version of call_ref, but since return_call_ref has no users yet, update it in a single step.
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
| @@ -2014,7 +2014,13 @@ struct PrintExpressionContents | |||
| } | |||
| void visitCallRef(CallRef* curr) { | |||
| if (curr->isReturn) { | |||
| printMedium(o, "return_call_ref"); | |||
| if (printUnreachableReplacement(curr->target)) { | |||
There was a problem hiding this comment.
return calls are always unreachable aren't they? this would always happen then, unless I'm missing something.
There was a problem hiding this comment.
We're passing curr->target, so we only print the replacement if the target is unreachable.
| ;; CHECK-NEXT: (call $tail-caller-call_ref-unreachable) | ||
| ;; CHECK-NEXT: (drop | ||
| ;; CHECK-NEXT: (call $tail-caller-call_ref-unreachable) | ||
| ;; CHECK-NEXT: ) |
There was a problem hiding this comment.
Previously the text parser used ValidatingBuilder::validateAndMakeCallRef for return calls and that would produce an unreachable block expression rather than an actual call inside tail-caller-call_ref-unreachable. Now the parser actually produces a tail call CallRef expression there that prevents DAE from removing the return value, so that return value needs to be dropped here.
The GC spec has been updated to have heap type annotations on call_ref and
return_call_ref. To avoid breaking users, we will have a graceful, multi-step
upgrade to the annotated version of call_ref, but since return_call_ref has no
users yet, update it in a single step.