Add a mechanism to skip a pass by name #5448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example,
-O3 --skip-pass=vacuum
will run-O3
normally but it will not run thevacuum
pass at all (which normally runs more than once).The motivation for this is that J2Wasm wants to skip GlobalTypeOptimization in the
early cycles of optimization. We want to run
-O3
a few times without GTO first, asthat preserves the shape of the vtables and itables (GTO removes and changes
fields). After that we'll apply an optimization for itables and vtables. And after that
optimization cycles can use GTO normally. Rather than add a special
--skip-gto
flag, this PR adds a generic mechanism which could be useful for other things
later in principle.