Skip to content

Add a mechanism to skip a pass by name #5448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 24, 2023
Merged

Add a mechanism to skip a pass by name #5448

merged 5 commits into from
Jan 24, 2023

Conversation

kripken
Copy link
Member

@kripken kripken commented Jan 24, 2023

For example, -O3 --skip-pass=vacuum will run -O3 normally but it will not run the
vacuum pass at all (which normally runs more than once).

The motivation for this is that J2Wasm wants to skip GlobalTypeOptimization in the
early cycles of optimization. We want to run -O3 a few times without GTO first, as
that preserves the shape of the vtables and itables (GTO removes and changes
fields). After that we'll apply an optimization for itables and vtables. And after that
optimization cycles can use GTO normally. Rather than add a special --skip-gto
flag, this PR adds a generic mechanism which could be useful for other things
later in principle.

@kripken kripken requested review from tlively and aheejin January 24, 2023 19:23
@kripken kripken merged commit 5aa94e0 into main Jan 24, 2023
@kripken kripken deleted the skip.pass branch January 24, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants