[NFC] Templatize makeBlock so it can be used with any iterable
#5583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the different overloads we previously had for different kinds of containers with generic templates. We still need dedicated overloads for `std::initializer_list` because it is never inferred in a template context, though. Also, since `std::initializer_list` does not allow subscripting, update the arena vector implementation to use iterators instead now that initializer lists can be passed down to that layer without being reified as vectors.
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
kripken
approved these changes
Mar 16, 2023
|
|
||
| template<typename T> | ||
| using bool_if_not_expr_t = | ||
| std::enable_if_t<std::negation_v<std::is_convertible<T, Expression*>>, |
There was a problem hiding this comment.
Btw, any idea why I couldn't get this to work with std::is_base_of instead of is_convertible?
There was a problem hiding this comment.
I think it has to do with having to remove the pointer, presumably using std::remove_pointer, although TBH I couldn't get that working either, so I'm definitely missing something else there, too.
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
…Assembly#5583) Replace the different overloads we previously had for different kinds of containers with generic templates. We still need dedicated overloads for `std::initializer_list` because it is never inferred in a template context, though. Also, since `std::initializer_list` does not allow subscripting, update the arena vector implementation to use iterators instead now that initializer lists can be passed down to that layer without being reified as vectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the different overloads we previously had for different kinds of
containers with generic templates. We still need dedicated overloads for
std::initializer_listbecause it is never inferred in a template context,though. Also, since
std::initializer_listdoes not allow subscripting, updatethe arena vector implementation to use iterators instead now that initializer
lists can be passed down to that layer without being reified as vectors.