Skip to content

[Parser] Parse tuple types #6249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2024
Merged

[Parser] Parse tuple types #6249

merged 2 commits into from
Jan 29, 2024

Conversation

tlively
Copy link
Member

@tlively tlively commented Jan 26, 2024

Use the new (tuple ...) syntax. Enforce that tuples have a valid number of
elements and are not nested to avoid assertion failures when parsing invalid
input.

@tlively tlively requested a review from kripken January 26, 2024 18:39
@tlively
Copy link
Member Author

tlively commented Jan 26, 2024

Use the new `(tuple ...)` syntax. Enforce that tuples have a valid number of
elements and are not nested to avoid assertion failures when parsing invalid
input.
@tlively tlively force-pushed the parser-tuple-types branch from 4a4c934 to d823f1c Compare January 29, 2024 18:27
@tlively
Copy link
Member Author

tlively commented Jan 29, 2024

Merge activity

  • Jan 29, 6:36 PM: @tlively started a stack merge that includes this pull request via Graphite.
  • Jan 29, 6:36 PM: @tlively merged this pull request with Graphite.

@tlively tlively merged commit 9a31d7e into main Jan 29, 2024
@tlively tlively deleted the parser-tuple-types branch January 29, 2024 23:36
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
Use the new `(tuple ...)` syntax. Enforce that tuples have a valid number of
elements and are not nested to avoid assertion failures when parsing invalid
input.
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants