[Parser] Do not eagerly lex numbers #6544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
This stack of PRs brings us from being ~8% slower than the old parser to being ~30% faster 🎉 |
kripken
approved these changes
Apr 25, 2024
| } | ||
| return getIndex(); | ||
| } | ||
| size_t getPos() const { return index; } |
There was a problem hiding this comment.
Maybe worth renaming index to pos or vice versa?
There was a problem hiding this comment.
Yeah, we actually also have a getIndex method that does the same thing. Now that they are the same, it would be good to clean this up. I'll take a look at it as a follow-up.
tlively
force-pushed
the
parser-no-tok-string
branch
from
7c48a77 to
2cfb8a1
Compare
tlively
force-pushed
the
parser-no-tok-nums
branch
from
6bf227b to
1c0f12e
Compare
tlively
force-pushed
the
parser-no-tok-string
branch
from
2cfb8a1 to
fb535c3
Compare
tlively
force-pushed
the
parser-no-tok-nums
branch
2 times, most recently
from
dc21b29 to
17ec230
Compare
tlively
changed the title
tlively
force-pushed
the
parser-no-tok-string
branch
from
d6a6223 to
15d01ea
Compare
Lex integers and floats on demand to avoid wasted work. Remove `Token` completely now that all kinds of tokens are lexed on demand.
tlively
force-pushed
the
parser-no-tok-nums
branch
from
17ec230 to
f07ff79
Compare
18 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lex integers and floats on demand to avoid wasted work. Remove
Tokencompletely now that all kinds of tokens are lexed on demand.