Skip to content

Make it possible to skip several passes #6714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 3 commits into from
Jul 17, 2024
Merged

Make it possible to skip several passes #6714

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ace9b3
Make it possible to skip several passes
vouillon Jul 5, 2024
80d3a28
Test fixes
vouillon Jul 16, 2024
57ee8b8
Fix comments
vouillon Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tools/optimization-options.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ struct OptimizationOptions : public ToolOptions {
"-sp",
"Skip a pass (do not run it)",
OptimizationOptionsCategory,
Options::Arguments::One,
Options::Arguments::N,
[this](Options*, const std::string& pass) {
passOptions.passesToSkip.insert(pass);
});
Expand Down
67 changes: 67 additions & 0 deletions test/lit/passes/O1_skip_passes.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
;; NOTE: Assertions have been generated by update_lit_checks.py and should not be edited.

;; RUN: foreach %s %t wasm-opt -O2 --skip-pass=coalesce-locals --skip-pass=simplify-locals --skip-pass=simplify-locals-nostructure -S -o - 2>&1 | filecheck %s

;; Check that we can skip several passes. Note that no local.tee is introduced.

;; There should also be no warning in the output.

Copy link
Copy Markdown
Member

@kripken kripken Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
;; There should also be no warning in the output.

May as well delete this as the test is not verifying that atm. (It could in theory if we added additional stuff here, but I don't think it's worth it.)

(module
;; CHECK: (import "a" "b" (func $log (param i32 i32)))
(import "a" "b" (func $log (param i32 i32)))

;; CHECK: (func $foo (param $p i32)
;; CHECK-NEXT: (local $x i32)
;; CHECK-NEXT: (local $y i32)
;; CHECK-NEXT: (local.set $x
;; CHECK-NEXT: (i32.add
;; CHECK-NEXT: (local.get $p)
;; CHECK-NEXT: (i32.const 1)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
;; CHECK-NEXT: (call $log
;; CHECK-NEXT: (local.get $x)
;; CHECK-NEXT: (local.get $x)
;; CHECK-NEXT: )
;; CHECK-NEXT: (local.set $y
;; CHECK-NEXT: (i32.add
;; CHECK-NEXT: (local.get $p)
;; CHECK-NEXT: (i32.const 1)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
;; CHECK-NEXT: (call $log
;; CHECK-NEXT: (local.get $y)
;; CHECK-NEXT: (local.get $y)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
(func $foo (export "foo") (param $p i32)
;; The locals $x and $y can be coalesced into a single local, but as
;; we do not run that pass, they will not be. The could be
Copy link
Copy Markdown
Member

@kripken kripken Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
;; we do not run that pass, they will not be. The could be
;; we do not run that pass, they will not be. They could be

;; initialized using a tee but the passes that introduce tees are
;; not run either.
(local $x i32)
(local $y i32)

(local.set $x
(i32.add
(local.get $p)
(i32.const 1)
)
)
(call $log
(local.get $x)
(local.get $x)
)

(local.set $y
(i32.add
(local.get $p)
(i32.const 1)
)
)
(call $log
(local.get $y)
(local.get $y)
)
)
)