[Custom Descriptors] Fix shared GTO placeholders #7907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we optimize a descriptor to describe a placeholder type because the original described type no longer needs a descriptor, we were not previously ensuring that the sharedness of the placeholder matched the sharedness of the descriptor type. Make sure the shareness matches to avoid validation errors when rebuilding the types.
kripken
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we optimize a descriptor to describe a placeholder type because the
original described type no longer needs a descriptor, we were not
previously ensuring that the sharedness of the placeholder matched the
sharedness of the descriptor type. Make sure the shareness matches to
avoid validation errors when rebuilding the types.