Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Inconsistency between except_ref and anyref/anyfunc #79

Closed
gahaas opened this issue Mar 19, 2019 · 5 comments
Closed

Inconsistency between except_ref and anyref/anyfunc #79

gahaas opened this issue Mar 19, 2019 · 5 comments

Comments

@gahaas
Copy link
Contributor

gahaas commented Mar 19, 2019

This proposal spells the type except_ref with _, but the official spec and the Reference Type proposal write the reference types anyref and anyfunc without _. I think the spelling of these types should be consistent.
@rossberg
Copy link
Member

rossberg commented Mar 19, 2019 •
edited
Loading

I'd propose exnref, which is shorter while using a somewhat more established abbreviation.

(Note that anyfunc has been renamed to funcref.)

@binji
Copy link
Member

binji commented Mar 19, 2019

exnref seems OK to me. I haven't seen exn much before, but a quick search shows it's common in ML- and scheme-like languages.

@gahaas
Copy link
Contributor Author

gahaas commented Mar 20, 2019

exnref sounds good to me.

@mstarzinger
Copy link

+1 to exnref from my side as well (sorry for being late to the party).

aheejin added a commit to aheejin/exception-handling that referenced this issue Jul 14, 2019
@aheejin
Rename except_ref type to exnref
c36bf40 
In WebAssembly#79 we agreed to change `except_ref` to `exnref`.
aheejin added a commit to aheejin/exception-handling that referenced this issue Jul 14, 2019
@aheejin
Rename except_ref type to exnref
d2f0bb1 
In WebAssembly#79 we agreed to change `except_ref` to `exnref`.
@aheejin aheejin mentioned this issue Jul 14, 2019
Merged
aheejin added a commit that referenced this issue Jul 14, 2019
@aheejin
Rename except_ref type to exnref (#84)
7779599 
In #79 we agreed to change `except_ref` to `exnref`.
aheejin added a commit to aheejin/binaryen that referenced this issue Jul 14, 2019
@aheejin
Rename except_ref type to exnref
81bb638 
In WebAssembly/exception-handling#79 we agreed to rename `except_ref`
type to `exnref`.
@aheejin aheejin mentioned this issue Jul 14, 2019
Merged
aheejin added a commit to aheejin/binaryen that referenced this issue Jul 14, 2019
@aheejin
Rename except_ref type to exnref
91a3149 
In WebAssembly/exception-handling#79 we agreed to rename `except_ref`
type to `exnref`.
aheejin added a commit to WebAssembly/binaryen that referenced this issue Jul 14, 2019
@aheejin
Rename except_ref type to exnref (#2224)
cdab4ef 
In WebAssembly/exception-handling#79 we agreed to rename `except_ref`
type to `exnref`.
llvm-git-migration pushed a commit to llvm/llvm-project that referenced this issue Jul 15, 2019
@aheejin
[WebAssembly] Rename except_ref type to exnref
9f96a58 
Summary:
We agreed to rename `except_ref` to `exnref` for consistency with other
reference types in
WebAssembly/exception-handling#79. This also
renames WebAssemblyInstrExceptRef.td to WebAssemblyInstrRef.td in order
to use the file for other reference types in future.

Reviewers: dschuff

Subscribers: sbc100, jgravelle-google, hiraditya, sunfish, jfb, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64703

llvm-svn: 366145
dtzWill pushed a commit to llvm-mirror/lld that referenced this issue Jul 15, 2019
@aheejin
[WebAssembly] Rename except_ref type to exnref
15a3062 
Summary:
We agreed to rename `except_ref` to `exnref` for consistency with other
reference types in
WebAssembly/exception-handling#79. This also
renames WebAssemblyInstrExceptRef.td to WebAssemblyInstrRef.td in order
to use the file for other reference types in future.

Reviewers: dschuff

Subscribers: sbc100, jgravelle-google, hiraditya, sunfish, jfb, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64703

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@366145 91177308-0d34-0410-b5e6-96231b3b80d8
dtzWill pushed a commit to llvm-mirror/llvm that referenced this issue Jul 15, 2019
@aheejin
[WebAssembly] Rename except_ref type to exnref
b29d4ba 
Summary:
We agreed to rename `except_ref` to `exnref` for consistency with other
reference types in
WebAssembly/exception-handling#79. This also
renames WebAssemblyInstrExceptRef.td to WebAssemblyInstrRef.td in order
to use the file for other reference types in future.

Reviewers: dschuff

Subscribers: sbc100, jgravelle-google, hiraditya, sunfish, jfb, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64703

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@366145 91177308-0d34-0410-b5e6-96231b3b80d8
@aheejin
Copy link
Member

aheejin commented Jul 15, 2019

Changed in

Closing the issue.

@aheejin aheejin closed this as completed Jul 15, 2019
earl pushed a commit to earl/llvm-mirror that referenced this issue Jul 15, 2019
@aheejin
[WebAssembly] Rename except_ref type to exnref
ad30df4 
Summary:
We agreed to rename `except_ref` to `exnref` for consistency with other
reference types in
WebAssembly/exception-handling#79. This also
renames WebAssemblyInstrExceptRef.td to WebAssemblyInstrRef.td in order
to use the file for other reference types in future.

Reviewers: dschuff

Subscribers: sbc100, jgravelle-google, hiraditya, sunfish, jfb, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64703

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@366145 91177308-0d34-0410-b5e6-96231b3b80d8
aheejin added a commit to aheejin/wabt that referenced this issue Aug 12, 2019
@aheejin
Rename except_ref type to exnref
2d49250 
In WebAssembly/exception-handling#79 we agreed to rename except_ref
type to exnref.
aheejin added a commit to aheejin/wabt that referenced this issue Aug 12, 2019
@aheejin
Rename except_ref type to exnref
a1d4358 
In WebAssembly/exception-handling#79 we agreed to rename except_ref
type to exnref.
@aheejin aheejin mentioned this issue Aug 12, 2019
Merged
aheejin added a commit to WebAssembly/wabt that referenced this issue Aug 12, 2019
@aheejin
Rename except_ref type to exnref (#1142)
a9c001a 
In WebAssembly/exception-handling#79 we agreed to rename except_ref
type to exnref.
ioannad pushed a commit to ioannad/exception-handling that referenced this issue Jun 6, 2020
@Ms2ger
[js-api] Extend with reference types support. (WebAssembly#79)
2028231 
* [js-api] Remove spurious argument to ToWebAssemblyValue().

Fixes WebAssembly#51.

* [js-api] Extend the WebAssembly.Table API.

Fixes WebAssembly#22.
Fixes WebAssembly#67.
@jayphelps jayphelps mentioned this issue Jun 9, 2020
Closed
ioannad pushed a commit to ioannad/exception-handling that referenced this issue Feb 23, 2021
@aheejin @ioannad
Rename except_ref type to exnref (WebAssembly#84)
8225dab 
In WebAssembly#79 we agreed to change `except_ref` to `exnref`.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mstarzinger @binji @rossberg @aheejin @gahaas