This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Move event section before global section #98
Comments
|
Sounds good. I requested this change in v8. Will change this in LLVM / Binaryen/ Wabt after V8 change is implemented. |
aheejin
added a commit
to aheejin/exception-handling
that referenced
this issue
Feb 11, 2020
aheejin
added a commit
that referenced
this issue
Feb 11, 2020
aheejin
added a commit
to aheejin/conditional-sections
that referenced
this issue
Feb 12, 2020
We decided to move the event section before the global section WebAssembly/exception-handling#98.
tlively
pushed a commit
to WebAssembly/conditional-sections
that referenced
this issue
Feb 12, 2020
We decided to move the event section before the global section WebAssembly/exception-handling#98.
pull bot
pushed a commit
to p-g-krish/v8
that referenced
this issue
Mar 23, 2020
Before, it was specified between the globals and the exports section. This changed with WebAssembly/exception-handling#98. The event section is now placed between the memory and the globals section. [email protected] [email protected] Bug: v8:10176 Change-Id: Icafeaae4ff7796273c73d61ed417c028fcbcb02d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116032 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Clemens Backes <[email protected]> Cr-Commit-Position: refs/heads/master@{#66833}
aheejin
added a commit
to aheejin/wabt
that referenced
this issue
Mar 25, 2020
We decided move the event section before the global section in WebAssembly/exception-handling#98.
binji
pushed a commit
to WebAssembly/wabt
that referenced
this issue
Mar 25, 2020
We decided move the event section before the global section in WebAssembly/exception-handling#98.
aheejin
added a commit
to llvm/llvm-project
that referenced
this issue
Mar 25, 2020
Summary: WebAssembly/exception-handling#98 Also this moves many parts of code to make code align with the section order, even if they don't affect the output. Reviewers: tlively Subscribers: dschuff, sbc100, hiraditya, sunfish, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D76752
|
This has been reflected in: Closing this. |
arichardson
pushed a commit
to arichardson/llvm-project
that referenced
this issue
Apr 2, 2020
Summary: WebAssembly/exception-handling#98 Also this moves many parts of code to make code align with the section order, even if they don't affect the output. Reviewers: tlively Subscribers: dschuff, sbc100, hiraditya, sunfish, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D76752
ioannad
pushed a commit
to ioannad/exception-handling
that referenced
this issue
Jun 6, 2020
ioannad
pushed a commit
to ioannad/exception-handling
that referenced
this issue
Feb 23, 2021
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this issue
Oct 7, 2022
Summary: WebAssembly/exception-handling#98 Also this moves many parts of code to make code align with the section order, even if they don't affect the output. Reviewers: tlively Subscribers: dschuff, sbc100, hiraditya, sunfish, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D76752
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The proposal currently positions the event section after the global section. However, it is perceivable that under some future extensions, the initialiser expressions for a global might be generalised such that they can contain instructions that refer to exceptions. At the same time, there is no apparent reason to assume that exception defs would ever need to refer to globals.
Thus, in order to keep validation as single-pass as possible, I'd propose switching the order of global and event section in the binary format.
The text was updated successfully, but these errors were encountered: