Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Organize old proposals #136

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Conversation

aheejin
Copy link
Member

@aheejin aheejin commented Oct 6, 2020

This renames existing old proposals by adding a version number to
filenames and adds the current (=soon-to-be-previous) proposal to the
old/folder as well.

This renames existing old proposals by adding a version number to
filenames and adds the current (=soon-to-be-previous) proposal to the
old/folder as well.
@aheejin aheejin requested a review from tlively October 6, 2020 23:37
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to move the explainer rather than copying it? Kind of strange to have two copies of the same document in the repo, even if it's temporary.

@aheejin
Copy link
Member Author

aheejin commented Oct 7, 2020

But then the next PR will be not a diff against the current version but a whole new document, which I don't think we want?

@tlively
Copy link
Member

tlively commented Oct 7, 2020

Good point. LGTM!

@aheejin aheejin merged commit 4c16703 into WebAssembly:master Oct 7, 2020
@aheejin aheejin deleted the move_old_proposal branch October 7, 2020 15:43
ioannad pushed a commit to ioannad/exception-handling that referenced this pull request Feb 23, 2021
This renames existing old proposals by adding a version number to
filenames and adds the current (=soon-to-be-previous) proposal to the
old/folder as well.
ioannad pushed a commit to ioannad/exception-handling that referenced this pull request Feb 23, 2021
This renames existing old proposals by adding a version number to
filenames and adds the current (=soon-to-be-previous) proposal to the
old/folder as well.
Ms2ger pushed a commit to Ms2ger/exception-handling that referenced this pull request Jun 24, 2021
Decoding 64 as an signed LEB will produce the value -64 = 4294967232.
This change adds tests to ensure that the segment is decoded as 64.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants