This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Use the second proposal #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we have voted for the second proposal, change the document to represent the right one.
binji
reviewed
Nov 6, 2018
binji
reviewed
Nov 7, 2018
dschuff
reviewed
Nov 7, 2018
dschuff
approved these changes
Nov 7, 2018
ioannad
pushed a commit
to ioannad/exception-handling
that referenced
this pull request
Jun 6, 2020
* The data count section is required if the `memory.init` or `data.drop` instructions are used. * `memory.init` had an off-by-one bug when reading at the end of a segment. * All instructions that operate on regions need to compare length to 0 using unsigned comparison (e.g. `I32.gt_u n 0l`). * Converting length from 32- to 64-bit now uses `I64_convert.extend_i32_u`, instead of `Int64.of_int32`, since the latter will sign-extend. * The `table.copy` overlap test now uses an unsigned comparison. * The passive element text syntax still allows function indexes, e.g. `(elem passive $f1 $f2)`. * Add element type to passive element segments
ioannad
pushed a commit
to ioannad/exception-handling
that referenced
this pull request
Feb 23, 2021
Now we have voted for the second proposal, change the document to represent the right one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have voted for the second proposal, change the document to
represent the right one.