Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Add negated versions of br_on_* instructions #213

Merged
merged 2 commits into from
May 11, 2021
Merged

Add negated versions of br_on_* instructions #213

merged 2 commits into from
May 11, 2021

Conversation

rossberg
Copy link
Member

As a result of the discussion on WebAssembly/function-references#45, this adds inverse versions of the br_on_* and br_cast instructions as well.

@rossberg rossberg requested a review from jakobkummerow May 10, 2021 14:43
@@ -501,6 +537,7 @@ The opcode for heap types is encoded as an `s33`.
| 0xfb40 | `ref.test $t` | `$t : typeidx` |
| 0xfb41 | `ref.cast $t` | `$t : typeidx` |
| 0xfb42 | `br_on_cast $l` | `$l : labelidx` |
| 0xfb42 | `br_on_cast_fail $l` | `$l : labelidx` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 0xfb43.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

Copy link
Contributor

@jakobkummerow jakobkummerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rossberg rossberg merged commit fed8940 into master May 11, 2021
@rossberg rossberg deleted the br_on_non branch May 11, 2021 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants