This repository was archived by the owner on Nov 3, 2021. It is now read-only.
Use blocktype binary encoding for the new typed select instruction #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently proposed typed select instruction encodes its type immediate as
vec valtype
. IMO it's better for the typed select instruction to use theblocktype
encoding from the multi-value extension. It's fixed length, and involves little additional specification/code to reuse theblocktype
encoding.The caveat is that this repo does not have the generalization of block types added by the multi-value repo, so the new select instruction needs to be restricted to arity 1 at the syntax level instead of in validation, as it is currently proposed. The intent is that when this repo and the multi-value repo are merged, the syntax will be relaxed to allow block types with arity > 1, and the validation/execution of the multi-value select will be specified.