Skip to content

Support new dylink.0 custom section format #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2021
Merged

Support new dylink.0 custom section format #1707

merged 1 commit into from
Sep 10, 2021

Conversation

sbc100
Copy link
Member

@sbc100 sbc100 commented Sep 10, 2021 •
edited
Loading

This section is now based on sub-sections making it more
extensible.

See also:
llvm change: https://reviews.llvm.org/D109595
binaryen change: WebAssembly/binaryen#4141

@sbc100 sbc100 requested a review from dschuff September 10, 2021 11:54
sbc100 added a commit to WebAssembly/binaryen that referenced this pull request Sep 10, 2021
@sbc100
Support new dylink.0 custom section format
c7e60d3 
See also:
llvm change: https://reviews.llvm.org/D109595
wabt change: WebAssembly/wabt#1707
@sbc100 sbc100 mentioned this pull request Sep 10, 2021
Merged
sbc100 added a commit to WebAssembly/binaryen that referenced this pull request Sep 10, 2021
@sbc100
Support new dylink.0 custom section format
f82ccb0 
See also:
llvm change: https://reviews.llvm.org/D109595
wabt change: WebAssembly/wabt#1707
sbc100 added a commit to WebAssembly/binaryen that referenced this pull request Sep 10, 2021
@sbc100
Support new dylink.0 custom section format
820e67c 
See also:
llvm change: https://reviews.llvm.org/D109595
wabt change: WebAssembly/wabt#1707
sbc100 added a commit to emscripten-core/emscripten that referenced this pull request Sep 10, 2021
@sbc100
Support new dylink.0 custom section format
0ec0103 
See also:
llvm change: https://reviews.llvm.org/D109595
wabt change: WebAssembly/wabt#1707
binaryen change: WebAssembly/binaryen#4141
This was referenced Sep 10, 2021
Merged
Merged
sbc100 added a commit to WebAssembly/tool-conventions that referenced this pull request Sep 10, 2021
@sbc100
DynamicLinking: Specify new "dylink" section format
ffedbd5 
llvm change: https://reviews.llvm.org/D109595
binaryen change: WebAssembly/binaryen#4141
wabt change:  WebAssembly/wabt#1707
emscripten change: emscripten-core/emscripten#15019
sbc100 added a commit to WebAssembly/binaryen that referenced this pull request Sep 10, 2021
@sbc100
Support new dylink.0 custom section format
068bfbf 
See also:
llvm change: https://reviews.llvm.org/D109595
wabt change: WebAssembly/wabt#1707
emscripten change: emscripten-core/emscripten#15019
sbc100 added a commit to emscripten-core/emscripten that referenced this pull request Sep 10, 2021
@sbc100
Support new dylink.0 custom section format
b1592d1 
See also:
llvm change: https://reviews.llvm.org/D109595
wabt change: WebAssembly/wabt#1707
binaryen change: WebAssembly/binaryen#4141
sbc100 added a commit to WebAssembly/tool-conventions that referenced this pull request Sep 10, 2021
@sbc100
DynamicLinking: Specify new "dylink" section format
9ee5fae 
llvm change: https://reviews.llvm.org/D109595
binaryen change: WebAssembly/binaryen#4141
wabt change:  WebAssembly/wabt#1707
emscripten change: emscripten-core/emscripten#15019
sbc100 added a commit to WebAssembly/tool-conventions that referenced this pull request Sep 10, 2021
@sbc100
DynamicLinking: Specify new "dylink" section format (#170)
b4e70a8 
llvm change: https://reviews.llvm.org/D109595
binaryen change: WebAssembly/binaryen#4141
wabt change:  WebAssembly/wabt#1707
emscripten change: emscripten-core/emscripten#15019
sbc100 added a commit to WebAssembly/binaryen that referenced this pull request Sep 10, 2021
@sbc100
Support new dylink.0 custom section format
569fda5 
See also:
llvm change: https://reviews.llvm.org/D109595
wabt change: WebAssembly/wabt#1707
emscripten change: emscripten-core/emscripten#15019
@dschuff
Copy link
Member

dschuff commented Sep 10, 2021

I guess onSymbol would be useful for something like a wabt-nm but isn't used now?

@dschuff
Copy link
Member

dschuff commented Sep 10, 2021

Actually, if onSymbol currently actually works, maybe we should leave it (and maybe add a simple dumper) until I'm done investigating how we want LLVM to treat symbols (e.g. section vs binary offsets). It might be useful to check against LLVM.

dschuff
dschuff approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@sbc100
Copy link
Member Author

sbc100 commented Sep 10, 2021

I guess onSymbol would be useful for something like a wabt-nm but isn't used now?

onSymbol was replaced with the more specific OnFunctionSymbol, OnGlobalSymbol, etc, back in #769, I think this was just left over by mistake.

@sbc100
Copy link
Member Author

sbc100 commented Sep 10, 2021

I guess onSymbol would be useful for something like a wabt-nm but isn't used now?

onSymbol was replaced with the more specific OnFunctionSymbol, OnGlobalSymbol, etc, back in #769, I think this was just left over by mistake.

I split that out into its own CL anyway.

@sbc100
Support new dylink cusomt section format
e869381 
This section is now based on sub-sections making it more
extensible.

(Also remove unused OnSymbol callback).
@sbc100 sbc100 enabled auto-merge (squash) September 10, 2021 17:04
@sbc100 sbc100 merged commit 6c06537 into main Sep 10, 2021
@sbc100 sbc100 deleted the dylink.0 branch September 10, 2021 17:35
sbc100 added a commit to WebAssembly/binaryen that referenced this pull request Sep 11, 2021
@sbc100
Support new dylink.0 custom section format
b0c3bd3 
See also:
llvm change: https://reviews.llvm.org/D109595
wabt change: WebAssembly/wabt#1707
emscripten change: emscripten-core/emscripten#15019
sbc100 added a commit to WebAssembly/binaryen that referenced this pull request Sep 11, 2021
@sbc100
Support new dylink.0 custom section format (#4141)
5b90e03 
See also:
spec change: WebAssembly/tool-conventions#170
llvm change: https://reviews.llvm.org/D109595
wabt change: WebAssembly/wabt#1707
emscripten change: emscripten-core/emscripten#15019
sbc100 added a commit to emscripten-core/emscripten that referenced this pull request Sep 11, 2021
@sbc100
Support new dylink.0 custom section format
b811d2a 
See also:
llvm change: https://reviews.llvm.org/D109595
wabt change: WebAssembly/wabt#1707
binaryen change: WebAssembly/binaryen#4141
sbc100 added a commit to emscripten-core/emscripten that referenced this pull request Sep 11, 2021
@sbc100
Support new dylink.0 custom section format
821b579 
See also:
llvm change: https://reviews.llvm.org/D109595
wabt change: WebAssembly/wabt#1707
binaryen change: WebAssembly/binaryen#4141
sbc100 added a commit to emscripten-core/emscripten that referenced this pull request Sep 11, 2021
@sbc100
Support new dylink.0 custom section format (#15019)
73c20f6 
See also:
llvm change: https://reviews.llvm.org/D109595
wabt change: WebAssembly/wabt#1707
binaryen change: WebAssembly/binaryen#4141
sbc100 added a commit to llvm/llvm-project that referenced this pull request Sep 12, 2021
@sbc100
[WebAssembly] Convert to new "dylink.0" section format
b78c85a 
This format is based on sub-sections (like the "linking" and "name"
sections) and is therefore easier to extend going forward.

spec change: WebAssembly/tool-conventions#170
binaryen change: WebAssembly/binaryen#4141
wabt change:  WebAssembly/wabt#1707
emscripten change: emscripten-core/emscripten#15019

Differential Revision: https://reviews.llvm.org/D109595
CDLlo pushed a commit to CDLlo/emscripten that referenced this pull request Oct 4, 2021
@sbc100 @CDLlo
Support new dylink.0 custom section format (emscripten-core#15019)
617ddb5 
See also:
llvm change: https://reviews.llvm.org/D109595
wabt change: WebAssembly/wabt#1707
binaryen change: WebAssembly/binaryen#4141
mem-frob pushed a commit to draperlaboratory/hope-llvm-project that referenced this pull request Oct 7, 2022
@sbc100
[WebAssembly] Convert to new "dylink.0" section format
a5a9cea 
This format is based on sub-sections (like the "linking" and "name"
sections) and is therefore easier to extend going forward.

spec change: WebAssembly/tool-conventions#170
binaryen change: WebAssembly/binaryen#4141
wabt change:  WebAssembly/wabt#1707
emscripten change: emscripten-core/emscripten#15019

Differential Revision: https://reviews.llvm.org/D109595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschuff dschuff dschuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @dschuff