Port the wasi-filesystem API to the new wai format. #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds to the template some configuration for CI to automatically verify that `*.abi.md` files are up-to-date, and additionally adds a `*.abi.md` file for the current example.
This makes a number of changes, to make use of interface-types features such as `expected`, variant types, and resources. The change to use resources in particular means that filesystem functions are now methods of the `descriptor` resource. Since this means renaming everything, take this opportunity to introduce a new naming conventions, with `_at` being used for functions that take dirfd+path arguments. This also eliminates the `rights` concept what was present in earlier versions of WASI, has has discussed in WebAssembly#31. This required adding new flags to `open_at`, so while here, this also adds basic `chmod`-like support, as discussed in WebAssembly#33. And, this removes support for readdir seeking (seekdir/telldir), as discussed in WebAssembly#7. And it adds a fifo file type and a more general socket type, as discussed in
|
I'm attempting to make a pull request that rebases this repo based on https://github.com/linclark/wasi-proposal-template, however it appears Github doesn't allow PRs that don't have any common history. |
sunfishcode
added a commit
to sunfishcode/wasi-filesystem
that referenced
this pull request
Nov 22, 2021
This makes a number of changes, to make use of interface-types features such as expected, variant types, and resources. The change to use resources in particular means that filesystem functions are now methods of the descriptor resource. Since this means renaming everything, take this opportunity to introduce a new naming conventions, with _at being used for functions that take dirfd+path arguments. This also eliminates the rights concept what was present in earlier versions of WASI, has has discussed in WebAssembly#31. This required adding new flags to open_at, so while here, this also adds basic chmod-like support, as discussed in WebAssembly#33. And, this removes support for readdir seeking (seekdir/telldir), as discussed in WebAssembly#7. And it adds a fifo file type and a more general socket type, as discussed in WebAssembly#4.
sunfishcode
added a commit
that referenced
this pull request
Dec 15, 2021
This makes a number of changes, to make use of interface-types features such as expected, variant types, and resources. The change to use resources in particular means that filesystem functions are now methods of the descriptor resource. Since this means renaming everything, take this opportunity to introduce a new naming conventions, with _at being used for functions that take dirfd+path arguments. This also eliminates the rights concept what was present in earlier versions of WASI, has has discussed in #31. This required adding new flags to open_at, so while here, this also adds basic chmod-like support, as discussed in #33. And, this removes support for readdir seeking (seekdir/telldir), as discussed in #7. And it adds a fifo file type and a more general socket type, as discussed in #4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a number of changes, to make use of interface-types features such
as
expected, variant types, and resources. The change to use resources inparticular means that filesystem functions are now methods of the
descriptorresource. Since this means renaming everything, take this opportunity to
introduce a new naming conventions, with
_atbeing used for functions thattake dirfd+path arguments.
This also eliminates the
rightsconcept what was present in earlier versionsof WASI, has has discussed in #31. This required adding new flags to
open_at,so while here, this also adds basic
chmod-like support, as discussed in #33.And, this removes support for readdir seeking (seekdir/telldir), as discussed
in #7.
And it adds a fifo file type and a more general socket type, as discussed in