Populate the wasi-io proposal with very preliminary content. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds very simple I/O streams and I/O arrays witx definitions, which match read/write and pread/pwrite from wasi-filesystem, as a starting point.
lygstate
reviewed
Mar 10, 2021
|
|
||
| Note: This is similar to `size_t` in POSIX. | ||
|
|
||
| Size: 4 |
There was a problem hiding this comment.
Raise a question, in WebAssembly memory64, does this should be 8 byte?
There was a problem hiding this comment.
Yes; this docs.md is auto-generated from the witx sources, where this type is declared as (@witx usize), specifically to anticipate wasm64.
lygstate
reviewed
Mar 10, 2021
| Extension: Capabilities insufficient. | ||
|
|
||
| ## <a href="#rights" name="rights"></a> `rights`: `Record` | ||
| File descriptor rights, determining which actions may be performed. |
There was a problem hiding this comment.
Do we need add a rights_extended for future usage?
There was a problem hiding this comment.
It's a good idea, however it turns out the rights system isn't very useful, so it seems more likely that we'll just remove it altogether.
|
Merging; this is just prelinary content; I'm planning more to come here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds very simple I/O streams and I/O arrays witx definitions,
which match read/write and pread/pwrite from wasi-filesystem, as a
starting point.