Add an initial witx file for I/O Streams. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2021
radu-matei
reviewed
Mar 30, 2021
| ;;; amount of data has been consumed. The data is returned successfully | ||
| ;;; with a `$push`, and the next `read` or `skip` call will report the | ||
| ;;; failure. | ||
| $push |
There was a problem hiding this comment.
Should there be separate statuses here for streams that model the PUSH flag / flushing (like TCP) and a different one for indicating a possible failure?
What is the thinking behind having the same status for both?
There was a problem hiding this comment.
These are good questions :-). I filed #9 to think about these further.
Closed
radu-matei
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
LGTM
We can continue the discussion about the $push status in #9, and I'm in favor of merging sooner rather than later, so we can iterate on the API.
This also extends the ABI validator to allow multiple return types, as are used in the I/O streams interface.
And, add more comments about how errors and end-of-stream work.
Thinking about this more, returning the number of bytes along with a failure to indicate a partial success makes user code more complex. So I'm now thinking it's better to just have the interface be a single result which either succeeds or fails. This also removes dependence on the `$errno` type, as I/O types don't need the majority of the error values.
This may turn out to be too simplified, but we can iterator on it.
sunfishcode
force-pushed
the
sunfishcode/io-streams
branch
from
8bec7e3 to
1cd1b28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also extends the ABI validator to allow multiple return types, as
are used in the I/O streams interface.