Skip to content

Style guide #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikevoronov opened this issue Oct 21, 2019 · 1 comment
Open

Style guide #116

mikevoronov opened this issue Oct 21, 2019 · 1 comment

Comments

@mikevoronov
Copy link
Contributor

mikevoronov commented Oct 21, 2019

It would good to have a explicit style guide for contributors of this repo (and maybe others in Cranelift). Because there are some divergences between different files (like comment style here and here) and sometimes it hard to make code follow the style guide.

@sunfishcode
Copy link
Member

wasi-libc includes codes from several external sources, with differing style conventions, so when adding new code, we generally just follow the style of the nearest code.

That said, I agree we could be more consistent in our own code. I've lately been moving wasi-libc's own .c files from /* to // comments (#112, #110, #109); once those land we could do a follow-up to convert the few remaining places.

sunfishcode added a commit that referenced this issue Dec 20, 2019
This is purely a style change, in accordance with #116.
sunfishcode added a commit that referenced this issue Jan 17, 2020
This is purely a style change, in accordance with #116.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants