Enable support for utimes and futimesat.
#242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can both be implemented in terms of `utimensat`.
|
This is ready to go, and just needs a review. |
sbc100
approved these changes
Mar 10, 2022
| @@ -11,7 +13,12 @@ int __futimesat(int dirfd, const char *pathname, const struct timeval times[2]) | |||
| int i; | |||
| for (i=0; i<2; i++) { | |||
| if (times[i].tv_usec >= 1000000ULL) | |||
| #ifdef __wasilibc_unmodified_upstream // WASI has no syscall | |||
| return __syscall_ret(-EINVAL); | |||
There was a problem hiding this comment.
I wonder if this a common pattern if it would be worth at least defining __syscall_ret macro?
There was a problem hiding this comment.
I'm not necessarily opposed to it, but it feels a little awkward, because either:
- It introduces the Linux-specific convention of using negative values in [-4095,0) to represent errors, or
- It doesn't use this, which risks having it behave differently than the code calling it expects.
sunfishcode
added a commit
that referenced
this pull request
Mar 28, 2022
Fix a bug introduced in #242 noticed [here]: if `tv_usec` is out of range, then properly return an error code. [here]: 079adff#r69631767
sunfishcode
added a commit
that referenced
this pull request
Mar 28, 2022
Fix a bug introduced in #242 noticed [here]: if `tv_usec` is out of range, then properly return an error code. [here]: 079adff#r69631767
sunfishcode
added a commit
that referenced
this pull request
Mar 28, 2022
Fix a bug introduced in #242 noticed [here]: if `tv_usec` is out of range, then properly return an error code. [here]: 079adff#r69631767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These can both be implemented in terms of
utimensat.