Skip to content

Commit 90f6be7

Browse files
authored
Address #2185: Fix duplicated IDs for decode callbacks (#2253)
* Address #2185: Duplicate IDs for Decode callbacks The decode callbacks were multiply defining their arguments. Instead, just have the descriptions of the arguments just link back to the IDL that defines the args. * Update expected errors
1 parent 4800720 commit 90f6be7

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

expected-errs.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
WARNING: Multiple elements have the same ID 'dom-decodeerrorcallback-error'.
2-
Deduping, but this ID may not be stable across revisions.
3-
WARNING: Multiple elements have the same ID 'dom-decodesuccesscallback-decodeddata'.
4-
Deduping, but this ID may not be stable across revisions.
51
LINE: Can't find the 'contextOptions' argument of method 'OfflineAudioContext/constructor(numberOfChannels, length, sampleRate)' in the argumentdef block.
62
LINE: Can't find the 'destinationNode' argument of method 'AudioNode/connect(destinationParam, output)' in the argumentdef block.
73
LINE: Can't find the 'input' argument of method 'AudioNode/connect(destinationParam, output)' in the argumentdef block.

index.bs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1211,15 +1211,15 @@ Methods</h4>
12111211
Callback {{DecodeSuccessCallback()}} Parameters</h4>
12121212

12131213
<dl dfn-type=argument dfn-for="DecodeSuccessCallback()">
1214-
: <dfn>decodedData</dfn>, of type {{AudioBuffer}}
1214+
: {{DecodeSuccessCallback/decodedData!!argument}}</dfn>, of type {{AudioBuffer}}
12151215
:: The AudioBuffer containing the decoded audio data.
12161216
</dl>
12171217

12181218
<h4 id="callback-decodeerrorcallback-parameters" callback lt="DecodeErrorCallback()">
12191219
Callback {{DecodeErrorCallback()}} Parameters</h4>
12201220

12211221
<dl dfn-type=argument dfn-for="DecodeErrorCallback()">
1222-
: <dfn>error</dfn>, of type {{DOMException}}
1222+
: {{DecodeErrorCallback/error!!argument}}, of type {{DOMException}}
12231223
:: The error that occurred while decoding.
12241224
</dl>
12251225

0 commit comments

Comments
 (0)