Many Bikeshed errors when building index.html (broken IDL?) #2185
Labels
category: admin
Editorial changes that do not change the text. https://www.w3.org/policies/process/#class-1
Comments
sideshowbarker
added
Needs Discussion
|
Yes, these are known issues which is why we have an expected results file. When I last talked to @tabatkins about this these were issues in bikeshed, not the spec. The generated spec seems correct, but we do want to get these fixed, eventually. |
rtoy
added
the
category: admin
|
OK, given #2185 (comment) it’s fine by me to close this — if you already have an existing issue for tracking this. Or otherwise if this issue is now the tracking issue for it, then of course it’s also fine by me to keep this open :) |
|
Is there a bikeshed issue that tracks the problems? |
|
Hmm. I can't find any bikeshed issue on this. But I'm going to leave this webaudio issue open just so we have a record of the fact that we really do need to fix these, either in the spec or work with @tabatkins to figure out what's wrong. |
|
For the record, here are the results after updating to bikeshed this morning. We have many fewer issues now . |
|
See also speced/bikeshed#1191 for the sequence and record errors. The sequence error is probably a simple mistake since bikeshed handles |
rtoy
removed
Needs Discussion
|
Not sure what happened in #2185 (comment) but the current list is |
rtoy
added a commit
to rtoy/web-audio-api
that referenced
this issue
Jul 28, 2020
Fixing links to parameters to the constructor. Basically, we
previously had something like
```
{{PeriodicWave/PeriodicWave(context, options)/options!!argument}}
```
and replace it with
```
{{PeriodicWave/constructor(context, options)/options!!argument}}
```
rtoy
added a commit
to rtoy/web-audio-api
that referenced
this issue
Jul 28, 2020
Here we basically change the definitions for the arguments of node constructor from ``` <pre class=argumentdef for="Foo/constructor(options)"> ``` to ``` <pre class=argumentdef for="Foo/constructor()"> ``` Not sure why this works but it does.
padenot
pushed a commit
that referenced
this issue
Jul 30, 2020
* Address #2185: Fix some bikeshed errors Fixing links to parameters to the constructor. Basically, we previously had something like ``` {{PeriodicWave/PeriodicWave(context, options)/options!!argument}} ``` and replace it with ``` {{PeriodicWave/constructor(context, options)/options!!argument}} ``` * Fix MediaStreamAudioSourceNode/options!!argument Fixed the same way as for PeriodicWave. * Update expected results
padenot
pushed a commit
that referenced
this issue
Jul 31, 2020
* Address #2185: Fix some bikeshed errors Fixing links to parameters to the constructor. Basically, we previously had something like ``` {{PeriodicWave/PeriodicWave(context, options)/options!!argument}} ``` and replace it with ``` {{PeriodicWave/constructor(context, options)/options!!argument}} ``` * Fix MediaStreamAudioSourceNode/options!!argument Fixed the same way as for PeriodicWave. * Update expected results * Address #2185: Fix up more bikeshed errors Here we basically change the definitions for the arguments of node constructor from ``` <pre class=argumentdef for="Foo/constructor(options)"> ``` to ``` <pre class=argumentdef for="Foo/constructor()"> ``` Not sure why this works but it does. * Update expected results * Merge with main, fixing conflicts
rtoy
added a commit
to rtoy/web-audio-api
that referenced
this issue
Aug 3, 2020
The latest veresion of bikeshed has fixed the errors printed for `<sequence<unsigned long>` and `record<DOMString, double>`, so we can remove these lines.
rtoy
added a commit
that referenced
this issue
Aug 3, 2020
|
The current expected errors file is now: I think we need help from @tabatkins for the |
rtoy
added a commit
to rtoy/web-audio-api
that referenced
this issue
Aug 19, 2020
Updated bikeshed to the latest version and many bikeshed errors are gone. Update expected-errs.txt with the latest results.
rtoy
added a commit
that referenced
this issue
Aug 19, 2020
|
With PR #2239, the expected errors file is shorter now. We didn't change the spec since the last time, so these are fixes from bikeshed itself. The one about |
|
Yup, you should hopefully be getting a PR from the autokagami bot soon that'll fix the 'void' issue, or you can fix it yourself. |
|
Yep, already got that. The bot doesn't now how to handle our errors file, so I'm doing it by hand, Should land this change soon. |
|
For the record PR #2240 was the fix noted by the autokagami bot. So there's just a few more errors: |
rtoy
added a commit
to rtoy/web-audio-api
that referenced
this issue
Sep 25, 2020
The decode callbacks were multiply defining their arguments. Instead, just have the descriptions of the arguments just link back to the IDL that defines the args.
rtoy
added a commit
that referenced
this issue
Oct 12, 2020
* Address #2185: Duplicate IDs for Decode callbacks The decode callbacks were multiply defining their arguments. Instead, just have the descriptions of the arguments just link back to the IDL that defines the args. * Update expected errors
|
With PR #2253, the bikeshed errors are now: The last two about |
rtoy
added a commit
to rtoy/web-audio-api
that referenced
this issue
Oct 23, 2020
…dio#2253) * Address WebAudio#2185: Duplicate IDs for Decode callbacks The decode callbacks were multiply defining their arguments. Instead, just have the descriptions of the arguments just link back to the IDL that defines the args. * Update expected errors
rtoy
added a commit
that referenced
this issue
Nov 19, 2020
* Fix #1933: Use FrozeArray for AudioWorkletProcessor process() Instead of `sequence<sequence<Float32Array>>`, use `FrozenArray<FrozenArray<Float32Array>>`. Define a callback function as well. * Address review comments from karlt. Rename AudioWorkletProcessorCallback to AudioWorletProcessCallback The third parameter is an object, not frozen array. * Replace process() method with callback sections Several changes here in no particular order: - Tell bikeshed that `object` is the webidl concept - Fix parameter names for the process callback (plurals, as used in the descriptions) - Rename the dfn for "Processing an input buffer" from "process" to "processing-input-buffer". - Fix up links to `process()` to point to the right place. - The old section on the process method is broken up into two sections. The main one is renaming it to "callback AudioWorkletProcessCallback". This contains most fo the main text. A subsection then describes the parameters to the callback. * Update expected errors The callback idea fixes the errors from defining the process method. * Address some review comments * Describe what happens to inputs/outputs if things change Add text to say inputs/outputs are recycled unless the topology changes (number of channels, array is transferred). Then new arrays are allocated. * Address some review comments Still need description of how parameters are frozen. * Update README.md * Fix typo in "messsage" (#2255) * chore: Fix markdown for bold (#2258) * Update implementation-report.html Update for Safari and for Edge * Update implementation-report.html Update IDL results for newer browsers * Update implementation-report.html Update summaries for new browsers. Fails = 6573 - passes * Update implementation-report.html Date * Fix typo "atleast" (#2259) This isn't really a typo but an issue with bikeshed not leaving a space at line breaks. See speced/bikeshed#1470. * Address #2185: Fix duplicated IDs for decode callbacks (#2253) * Address #2185: Duplicate IDs for Decode callbacks The decode callbacks were multiply defining their arguments. Instead, just have the descriptions of the arguments just link back to the IDL that defines the args. * Update expected errors * Fix #2262: Clone bikeshed and install it (#2263) As a workaround, clone the bikeshed repo and install bikeshed from the repo. Ideally, want just want to use the version with pip3 instead of cloning the current version of bikeshed, but that's producing unexpected errors. We'll do this for now and recheck at some later date when bikeshed is updated and revert to the old version. * Fix #2257: Make channel ordering table visible in dark mode (#2264) When using dark mode, use a different background color for the even rows of the channel ordering table so that the entries are visible. While we're at it, make the headings for the audio node properties table, the audio param values table, and the enumeration description table look a little better in dark mode. This is done by specifying a brighter green to make it a bit more legible. * Add ECMAScript algorithm to freeze parameters. * Some cleanups. Co-authored-by: Chris Lilley <[email protected]> Co-authored-by: Tomohiro IKEDA <[email protected]>
|
With #2253 and #2250, we're now down to: I think these are all issues with bikeshed. |
|
Yes, they're still errors on Bikeshed's side. |
|
This issue is basically tracked at speced/bikeshed#1740. Since the only remaining bikeshed issues are due to bikeshed, I'm closing this, per discussion in the last teleconf with Ruth John. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I get many Bikeshed errors when building
index.htmlfromindex.bsusingcompile.sh.The errors seem mostly (or completely) related to IDL problems. I’m not sure if that’s because there’s a build step I’m missing, or what. I just run
compile.shdirectly:The text was updated successfully, but these errors were encountered: