-
Notifications
You must be signed in to change notification settings - Fork 172
Open
Labels
Needs EditsDecision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/Decision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/category: enhancementSubstantive changes that do not add new features. https://www.w3.org/policies/process/#class-3Substantive changes that do not add new features. https://www.w3.org/policies/process/#class-3size: SSmall amount of work expected to resolve.Small amount of work expected to resolve.
Description
decodeAudioData step 3/4 says:
- If audioData is detached, execute the following steps:
- Append promise to [[pending promises]].
- Detach the audioData ArrayBuffer. If this operations throws, jump to the step 3.
- Queue a decoding operation to be performed on another thread.
- Else, execute the following error steps:
- Let error be a DataCloneError.
- Reject promise with error, and remove it from [[pending promises]].
- Queue a media element task to invoke errorCallback with error.
That's backwards. The first case is for buffers which are not detached. This appears to have gotten broken in #2603; previously it said "If IsDetachedBuffer on audioData is false".
Also, the "jump to the step 3" part is incoherent.
Metadata
Metadata
Assignees
Labels
Needs EditsDecision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/Decision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/category: enhancementSubstantive changes that do not add new features. https://www.w3.org/policies/process/#class-3Substantive changes that do not add new features. https://www.w3.org/policies/process/#class-3size: SSmall amount of work expected to resolve.Small amount of work expected to resolve.