Skip to content

Address #2185: Fix some bikeshed errors #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2020
Merged

Address #2185: Fix some bikeshed errors #2233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63ff285
Address #2185: Fix some bikeshed errors
rtoy Jul 28, 2020
cdac790
Fix MediaStreamAudioSourceNode/options!!argument
rtoy Jul 28, 2020
1b1022d
Update expected results
rtoy Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions expected-errs.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ LINK ERROR: No 'argument' refs found for 'context' with for='MediaStreamAudioSou
<a data-lt="context" data-link-type="argument" data-link-for="MediaStreamAudioSourceNode/MediaStreamAudioSourceNode(context, options), MediaStreamAudioSourceNode/constructor(context, options)">context</a>
LINK ERROR: No 'argument' refs found for 'options' with for='MediaStreamAudioSourceNode/MediaStreamAudioSourceNode(context, options)'.
<a data-lt="options" data-link-type="argument" data-link-for="MediaStreamAudioSourceNode/MediaStreamAudioSourceNode(context, options), MediaStreamAudioSourceNode/constructor(context, options)">options</a>
LINK ERROR: No 'argument' refs found for 'options' with for='MediaStreamAudioSourceNode/MediaStreamAudioSourceNode()'.
{{MediaStreamAudioSourceNode/MediaStreamAudioSourceNode()/options!!argument}}
LINK ERROR: No 'argument' refs found for 'context' with for='MediaStreamTrackAudioSourceNode/MediaStreamTrackAudioSourceNode(context, options)'.
<a data-lt="context" data-link-type="argument" data-link-for="MediaStreamTrackAudioSourceNode/MediaStreamTrackAudioSourceNode(context, options), MediaStreamTrackAudioSourceNode/constructor(context, options)">context</a>
LINK ERROR: No 'argument' refs found for 'options' with for='MediaStreamTrackAudioSourceNode/MediaStreamTrackAudioSourceNode(context, options)'.
Expand All @@ -98,8 +96,6 @@ LINK ERROR: No 'argument' refs found for 'context' with for='PeriodicWave/Period
<a data-lt="context" data-link-type="argument" data-link-for="PeriodicWave/PeriodicWave(context, options), PeriodicWave/constructor(context, options), PeriodicWave/PeriodicWave(context), PeriodicWave/constructor(context)">context</a>
LINK ERROR: No 'argument' refs found for 'options' with for='PeriodicWave/PeriodicWave(context, options)'.
<a data-lt="options" data-link-type="argument" data-link-for="PeriodicWave/PeriodicWave(context, options), PeriodicWave/constructor(context, options), PeriodicWave/PeriodicWave(context), PeriodicWave/constructor(context)">options</a>
LINK ERROR: No 'argument' refs found for 'options' with for='PeriodicWave/PeriodicWave(context, options)'.
{{PeriodicWave/PeriodicWave(context, options)/options!!argument}}
LINK ERROR: No 'argument' refs found for 'context' with for='StereoPannerNode/StereoPannerNode(context, options)'.
<a data-lt="context" data-link-type="argument" data-link-for="StereoPannerNode/StereoPannerNode(context, options), StereoPannerNode/constructor(context, options), StereoPannerNode/StereoPannerNode(context), StereoPannerNode/constructor(context)">context</a>
LINK ERROR: No 'argument' refs found for 'options' with for='StereoPannerNode/StereoPannerNode(context, options)'.
Expand Down
4 changes: 2 additions & 2 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8028,7 +8028,7 @@ Constructors</h4>
: <dfn>MediaStreamAudioSourceNode(context, options)</dfn>
::
1. If the {{MediaStreamAudioSourceOptions/mediaStream}} member of
{{MediaStreamAudioSourceNode/MediaStreamAudioSourceNode()/options!!argument}} does not reference a
{{MediaStreamAudioSourceNode/constructor(context, options)/options!!argument}} does not reference a
{{MediaStream}} that has at least one
{{MediaStreamTrack}} whose
<code>kind</code> attribute has the value <code>"audio"</code>,
Expand Down Expand Up @@ -9031,7 +9031,7 @@ Constructors</h4>
<div algorithm="construct periodic wave">
1. Let <var>p</var> be a new {{PeriodicWave}} object. Let <dfn attribute for="PeriodicWave">\[[real]]</dfn> and <dfn attribute for="PeriodicWave">\[[imag]]</dfn> be two internal slots of type {{Float32Array}}, and let <dfn attribute for="PeriodicWave">\[[normalize]]</dfn> be an internal slot.

1. Process {{PeriodicWave/PeriodicWave(context, options)/options!!argument}} according to one of the following cases:
1. Process {{PeriodicWave/constructor(context, options)/options!!argument}} according to one of the following cases:
1. If both {{PeriodicWaveOptions/real|options.real}} and {{PeriodicWaveOptions/imag|options.imag}} are present
1. <span class="synchronous">If the lengths of {{PeriodicWaveOptions/real|options.real}} and {{PeriodicWaveOptions/imag|options.imag}} are different or if either length is less than 2, throw an {{IndexSizeError}} and abort this algorithm.</span>
1. Set {{[[real]]}} and {{[[imag]]}} to new arrays with the same length as {{PeriodicWaveOptions/real|options.real}}.
Expand Down