Fix #2281: CR 2020-12-15 #2283
Closed
Fix #2281: CR 2020-12-15 #2283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new CR for 2020-12
|
Well, that was unexpected. Travis fails but when I run bikeshed locally updated just now (like our Travis CI), I get no issues. |
|
@svgeesus Can you check that I made the right changes for CR? I'll have to figure out why Travis isn't like this, but maybe it doesn't matter as long as I can build it locally myself. The preview looks ok. |
|
Of course, this MUST NOT be merged to the main branch, since that's for the editor's branch. |
svgeesus
approved these changes
Dec 10, 2020
|
Ok great, this is good to build now. Then I can do the pubrules check and broken link check. |
added 2 commits
December 15, 2020 10:56
Link to implementation-report.html for the required Implementation Report metadata for CR.
Bikeshed complains about some ambiguous links so set the link-defaults to one of the links bikeshed suggests. We generally prefer the HTML version if available. The updated links are for - Promise - Worklet - worklet global scope type - worklet destination type - addModule - WorkletGlobalScope
|
I think we're all set now. bikeshed doesn't produce any new errors now. |
The actual candidate recommendation happened on a different date. Update them to match the actual date of publication.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new CR for 2020-12
Preview | Diff