AudioContext "interrupted" state #2611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @youennf - here's the interrupted state spec work for AudioContext. |
mjwilson-google
added
Agenda+
hoch
reviewed
Feb 24, 2025
|
@gabrielsanbrito You don't have to correct all instances in the entire document, but I think it makes sense to clean up the section (e.g. this specific algorithm) that we're working on. |
hoch
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
LGTM with nits
Let's wait for the review from @padenot, @chrisguttandin, or @mdjp. I think we can merge when we have one more +1.
padenot
requested changes
Mar 14, 2025
gabrielsanbrito
force-pushed
the
audiocontext-interrupted-state
branch
from
7cd94d7 to
ee7d7b1
Compare
gabrielsanbrito
force-pushed
the
audiocontext-interrupted-state
branch
from
ee7d7b1 to
b297541
Compare
|
@padenot Thanks for the comments! I have finished addressing them. Could you please have another and see if it looks good to you? |
padenot
approved these changes
Mar 17, 2025
|
@gabrielsanbrito Could you follow up on this error? Looks like there's one indentation error to be fixed. |
|
@hoch, @padenot @chrisguttandin Thanks for reviewing this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the specification to the AudioContext "interrupted" state. This change does not have Web Platform Tests, because web pages are not able to trigger interruptions themselves. Starting an interruption is a prerogative of the user agent.
Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/AudioContextInterruptedState/explainer.md
Preview | Diff