Skip to content

Make it clear promise is resolved as part of control message steps #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hoch merged 2 commits into from
Mar 4, 2025
Merged

Make it clear promise is resolved as part of control message steps #2627

hoch merged 2 commits into from
Mar 4, 2025

Conversation

@youennf
Copy link
Contributor

@youennf youennf commented Feb 25, 2025 •
edited by pr-preview bot
Loading

Fixes #2626

Preview | Diff

@hoch hoch self-requested a review February 25, 2025 17:16
hoch
hoch approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoch hoch merged commit dfcea38 into WebAudio:main Mar 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoch hoch hoch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Editorial] https://webaudio.github.io/web-audio-api/#dom-audiocontext-resume promise handling could be made more clearly

2 participants

@youennf @hoch