Skip to content

GoTo plugin #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 12, 2023
Merged

GoTo plugin #66

merged 4 commits into from
Dec 12, 2023

Conversation

andrelsm
Copy link
Contributor

@andrelsm andrelsm commented Dec 6, 2023

Adds Go To Line (ctrl-G) functionality, prompting and validating the target line number in a popup dialog.

Adds Go To Line (ctrl-G) functionality, prompting and validating the target line number in a popup dialog.
@andrelsm
Copy link
Contributor Author

andrelsm commented Dec 6, 2023

hi, WebCoder,

my first plugin... Tested in Chromium and Firefox. Other browsers seems to implement the needed features for it to work.

GoTo plugin in action:
https://github.com/WebCoder49/code-input/assets/1190616/bb96923b-ab75-456b-898b-5828e723515f

best regards
andrelsm

@WebCoder49
Copy link
Owner

Thank you so much for this! I should hopefully be able to test, merge, and release this by tomorrow! (Friday 2023-12-08 evening UTC).

@WebCoder49 WebCoder49 self-assigned this Dec 7, 2023
@andrelsm
Copy link
Contributor Author

andrelsm commented Dec 7, 2023

nice!

It needs a little fix

89c89
<         var fs, lh, S, T, c = -1, lines = textarea.value.split('\n');
---
>         var fs, lh, c, S, T, lines = textarea.value.split('\n');
104,108c104,106
<             if (n > 1) {
<                 // cursor positon just after n - 1 full lines
<                 c = lines.slice(0, n - 1).join('\n').length;
<             }
<                 
---
>             // cursor positon just after n - 1 full lines
>             c = lines.slice(0, n - 1).join('\n').length;
> 

[ ] andrelsm

@WebCoder49
Copy link
Owner

As I spent quite a while on the Ctrl+F bug, I'm afraid I won't have time to release this today, but the only step left for me is fully testing this and setting the version so it should be ready by Monday.

@andrelsm
Copy link
Contributor Author

andrelsm commented Dec 8, 2023

take it easy...

@WebCoder49
Copy link
Owner

WebCoder49 commented Dec 11, 2023

@andrelsm Thank you!

Thanks also for all of your contributions just now - I am afraid that I had less free time today than I thought but should be able to get this implemented and hopefully start on the other issues soon this week.

@WebCoder49 WebCoder49 merged commit 6b0b119 into WebCoder49:main Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants