Merged
Conversation
- Created a script for copying just the node binaries from a special tagged version node-7.5.0 that will be created in the whistle docker hub. copybins.sh - Created a script for testing whether or not a tag is present in a docker repository. Allows for building a version without the tag if the tag isn’t present. Can later additionally add to build the tag if the tag isn’t present then leverage the the tag later. - Added logic to check whether or not a certain binary is being installed or not in the circle.yaml. - Added node version information to the tagging so that if a node ci tool is generated the Node version tag is included in addition to the terraform and packer tags.
- Added logic automatically build the node binary tag and push it up to docker if the version set in circle.yml isn't found in the registry. - Will tag it with both a circleci build number and the expected generic tag so that both are available and neither should affect the :latest tag. - Increased Major Version tag to 2 - Adding Packages needed for scripts.
Author
|
Is it cool if I merge this one? |
pickgr
approved these changes
Mar 22, 2017
|
@disaac - feel free to merge... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*NOTE: Building the node tag takes over 30 minutes in circleci which is why it isn't added to the standard build process and a separate tag is used to copy the binaries from.