Fix building of e.g., vendor/tree-sitter-haskell-src/scanner.cc #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least this parser uses C++11 (lambda expressions) and C++14 features (lambda `auto` parameter types). Since the default C++ standard of compilers can vary, this patch explicitly sets C++14 mode when building any vendored C++ files.
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
+ Coverage 68.34% 68.35% +0.01%
==========================================
Files 11 11
Lines 2982 2983 +1
==========================================
+ Hits 2038 2039 +1
Misses 944 944
Continue to review full report at Codecov.
|
Owner
|
Thanks! What was the platform where you noticed this issue? |
Contributor
Author
|
I ran into this on macos-10.15.7 with I believe the system Clang ( |
Wilfred
pushed a commit
that referenced
this pull request
Feb 3, 2022
Co-authored-by: Erin Browning <[email protected]>
Wilfred
pushed a commit
that referenced
this pull request
Apr 14, 2022
New scanner.c to better handle newlines
benmanns
pushed a commit
to benmanns/difftastic
that referenced
this pull request
Jul 1, 2022
novusnota
added a commit
to novusnota-forks/difftastic
that referenced
this pull request
Aug 25, 2024
baruch
pushed a commit
to baruch/difftastic
that referenced
this pull request
Jun 2, 2025
Wilfred
pushed a commit
that referenced
this pull request
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least this parser uses C++11 (lambda expressions) and C++14 features
(lambda
autoparameter types). Since the default C++ standard ofcompilers can vary, this patch explicitly sets C++14 mode when building
any vendored C++ files.