Support Markdown diff highilighting #380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memcpy() with a null destination or source is undefined
Avoid undefined behaviour
fix path to repository
Use MDeiml/tree-sitter-markdown project to support Markdown as a supported language. The instructions provided in [documentation][] were used to add this tree-sitter parser for the Markdown syntax. [documentation]: https://difftastic.wilfred.me.uk/adding_a_parser.html
gurjeet
added a commit
to gurjeet/difftastic
that referenced
this pull request
Sep 20, 2022
TreeSitterConfig doesn't seem to have the `name` attribute, anymore. I discovered this discrepancy while integrating Markdown language parser in PR Wilfred#380.
Wilfred
pushed a commit
that referenced
this pull request
Oct 25, 2022
TreeSitterConfig doesn't seem to have the `name` attribute, anymore. I discovered this discrepancy while integrating Markdown language parser in PR #380.
Contributor
|
Just came across this today; I'd be interested. Would this PR be merged in principle (I presume yes, based on the manual)? What's needed to get this PR across the finish line? Rebasing, a regression test, anything else? |
Owner
|
Thanks for the PR! I'm hesitant to merge this before #372 is fixed, because changing one word in a large paragraph might be hard to read otherwise. |
|
Given the ubiquity of Markdown these days, merging this PR would be very welcome :) |
|
Something looks off, is it normal there are 170 commits in the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use MDeiml/tree-sitter-markdown project to support Markdown as a
supported language.
The instructions provided in documentation were used to add this
tree-sitter parser for the Markdown syntax.