-
Notifications
You must be signed in to change notification settings - Fork 414
Upgrade a number of dependencies across SemVer boundaries. #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the PR! This mostly looks good if you want to rebase. My only concern is the hashbrown change, because difftastic is extremely sensitive to hash performance. Could you confirm that performance is the same (see the |
|
I rebased (well, reimplemented) this PR:
I’ll attempt a benchmark next. |
b1675c1 to
83a9b6a
Compare
|
Working on Fedora Asahi Remix on an M2 laptop, with current …and with this PR, I don’t see anything concerning there, but please let me know if there’s something else you would like me to try. |
Update
itertools, strsim, owo-colors, strum, hashbrown, and line-numbers to current releases. In all cases, the upstream changelog is linked in the commit message (except owo-colors where none is available), I inspected the source for obvious issues, and I confirmed thatcargo teststill works.I did not touch
unicode-widthor any of thetree-sittercrates because I suspected that those updates might require more careful validation.