Skip to content

Conversation

@Wolfieheart
Copy link
Owner

@Wolfieheart Wolfieheart commented Sep 12, 2022

Description:

Adding in Custom Name Support - Easy and was deprioritized due to IRL Events


[CORE] Changes

Changes to the core of the plugin - Performance Fixes, Bug Fixes, New Features, New Permission Nodes, New Config Options etc.

  • [CORE] Add in Custom Naming Functionality
  • [CORE] Add in New Config Options
  • [CORE] Version bump to 1.19.2-37.3

[CI] Changes

Changes relating to the Continuous Integration of other Plugin APIs, Github Workflows, Issue Templates etc.

  • [x][CI] PlotSquared to 6.9.4

[DOC] Changes

Changes relating to plugin Documentation - See the Wiki for more info


[MISC] Changes

Changes that does not fit in the above list

Testing of this will be done by me later and be done by the requester.


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the ArmorStandEditor Project Owners have the copyright to use and modify my contribution under the ArmorStandEditor License for perpetuity.

@Wolfieheart Wolfieheart linked an issue Sep 12, 2022 that may be closed by this pull request
2 tasks
@Wolfieheart Wolfieheart added P1: Extra Debug Required Extra Debug Effort Required P3: Awaiting Final Check Final check over - Issue Reporter required for Review P1: BUG / Awaiting Debugging Awaiting Round 1 of Debubbing/Reproduction Work in Progress Things I am currently taking a look at labels Sep 12, 2022
@Wolfieheart
Copy link
Owner Author

Tested on 20:13:07 CEST on 12/09 with the following results:

  • Getting Values from Config Appropriately PASS
  • Cant Use Edit Tool without Item having the correct Name PASS
  • Rename EditTool in Anvil, should result in Menu Appearing PASS

@Wolfieheart Wolfieheart added P2: Debug Completed Debug Session and Through Testing has been completed P4: Ready for Merge! Ready to be Merged Into Master/Main and removed P1: Extra Debug Required Extra Debug Effort Required P1: BUG / Awaiting Debugging Awaiting Round 1 of Debubbing/Reproduction labels Sep 12, 2022
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Wolfieheart Wolfieheart merged commit f023285 into master Sep 12, 2022
@Wolfieheart Wolfieheart deleted the dev/118 branch September 12, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2: Debug Completed Debug Session and Through Testing has been completed P3: Awaiting Final Check Final check over - Issue Reporter required for Review P4: Ready for Merge! Ready to be Merged Into Master/Main Work in Progress Things I am currently taking a look at

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Naming and adding a description to the subject of the rack editor

2 participants