Travis: Add simple test for fixer conflicts to the build script #1196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By running the complete WPCS suite over the test case files, we should be able to catch at least some fixer conflicts early. The exit code should be 1 when all fixable errors have been fixed. The exit code will be 2 when not all fixable errors have been fixed, indicating a fixer conflict. The command will output a summary report which will indicate the files which "FAILED TO FIX".
JDGrimes
approved these changes
Oct 12, 2017
|
FYI: I'm talking with Greg about adding the same test against fixer conflicts upstream. An initial test run for fixer conflicts with the various upstream rulesets has identified nearly a hundred fixer conflicts. Quite a few of the bugs I have identified involve sniffs used within WPCS, so the fixes might well (positively) affect the WP core project. /cc @pento |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now squizlabs/PHP_CodeSniffer#1645 has been merged, I can pull the follow up PR to #1123.
By running the complete WPCS suite over the test case files, we should be able to catch at least some fixer conflicts early.
As PHPCS exits with an error code of
1when all fixable errors have been fixed correctly, we need to run the command twice over the test files to get a0exit code allowing the build to pass.Any other error code indicates a fixer conflict or other problem remaining.
The travis report will output a summary report which will indicate the files which "FAILED TO FIX" which can be used to start investigating the fixer conflict.