Primary button: Update disabled state to be less prominent. #70674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +24 B (0%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Thanks for the PR!
IMO, design-wise, the disabled state makes more sense now. However, I noticed that this doesn't work well with themes.
For Dark Theme (from storybook):
Using theme-ready variables like $components-color-gray-300 should help resolve this.
Related: #69646
|
Thanks for the review!
Nice. @ciampo do you have any insights on best next steps here? Happy to update the PR! |
|
Let's try and use the suggested variable, for the time being — and iterate later is we overehaul theming. |
jasmussen
force-pushed
the
update/disabled-primary-state
branch
from
0a713db to
7d31286
Compare
|
Thanks @yogeshbhutkar and Marco, I've updated with the variable and things look good! 
|
|
I went ahead and updated the text color variable as well, so that that's also aware of dark mode:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related to #63856 ("Disabled states of the primary variant are very prominent, and draw a lot of attention given their un-interactivity.")
Changes the color of a disabled primary button to gray.
Why?
This makes it less prominent, and reduces confusion around the button being interactive.
Testing Instructions
Add a new post and observe the disabled "Publish" button. In this PR it shoudl be gray.
Screenshots or screencast