Editor: Hide 'sticky' option for password-protected posts #70887
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
Size Change: +14 B (0%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
|
Thanks! Hiding/showing works as described. One question: should toggling between sticky and password fields also clear the selection? For instance, if you're setting a password to a post that's already sticky, or unchecking password and setting sticky the notice appears: Kapture.2025-07-24.at.16.27.57.mp4I think in the case of unchecking password and setting sticky in particular, the user should be able to save. Is that reproducible for other folks? In any case, I'll defer to @jameskoster |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Good catch, @ramonjd! The React component does clear out unsupported fields. That error happens only when a post is already sticky or password-protected and a new request sends conflicting values. The validation happens before actual values are updated in the DB. I'll create a core ticket based on the decision here. |
|
@jameskoster, when you've time, can I get a second opinion on this? 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #30373.
PR updates
PostStatuscomponent to hide the sticky post option when a password is set, preventing a saving error.Note
The issue suggests making this option only available for public posts, but as far as post saving is concerned, all options are valid except password-protected.
Why?
Currently, if you try to make a password-protected post sticky, saving will fail with an error.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2025-07-24.at.09.51.53.mp4