[WIP] Align comments with their related block (when comment sidebar is not pinned) #71619
+200
−72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #71393
This PR visually aligns comments beside (to the right of) the block they are related to. This is in the design spec for inline comments. Note that this does not apply when showing the "pinned" comment sidebar.
Why?
When commenting on a block, and replying to those comments in a thread, it makes sense to position the comments alongside the block so they are visually related. This becomes increasingly important as the number of comments or the document length increases.
How?
As discussed previously, this PR will attempt to put comments in a
<Popover>
component.Plan
Popover
elementChallenges
Testing Instructions
When ready for testing:
Testing Instructions for Keyboard
Screenshots or screencast