iAPI Router: Update router regions inside elements with data-wp-interactive
#71635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
added
[Type] Enhancement
|
I'm trying to replicate the current supported behavior for router regions with the new implementation, but I'm encountering issues when multiple regions use It's as if Preact gets confused and reverses the order in which these regions were initially rendered, changing, for example, the context ( It's been hard to debug so far. I'll keep investigating. |
2 tasks
|
Size Change: +432 B (+0.02%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 19ca66d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17867991827
|
DAreRodz
requested review from
nerrad,
ajitbohra and
luisherranz
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@luisherranz, I think this is ready for review. With the current implementation, elements with the I.e., this router region is updated: <div data-wp-interactive="example-1">
<div
data-wp-interactive="example-1/router-region"
data-wp-router-region="example-1/router-region"
>
<!-- content -->
</div>
</div>This one won't be updated: <div data-wp-interactive="example-1">
<div data-wp-router-region="example-1/router-region">
<!-- content -->
</div>
</div>It's a problem that we can easily solve, just by modifying the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #71519
Adds support for elements with the
data-wp-router-regiondirective inside other elements withdata-wp-interactive.Why?
Currently, only elements with both
data-wp-router-regionanddata-wp-interactiveattributes, excluding those within an element withdata-wp-interactive, are considered regions and updated.This PR aims to handle any elements with
data-wp-router-regioninside an interactive element.See #71519 for more info.
How?
The main idea is to implement a
data-wp-router-regiondirective that controls the rendered element, changing its content according to the current page.Testing Instructions
It can be tested with core blocks with the following steps:
data-wp-interactive="test"to the corresponding HTML element.