Filter comment clause based on current query.

[peterwilsoncc]

What?

Fixes the comment filtering clause for block comments to avoid affecting subsequent queries.

Closes #71711

Why?

Affecting subsequent queries is bad.

How?

Moves the filtering to take place on comments_clauses exclusively by checking the query parameters on the clause filter.

The filter for pre_get_comments is removed.

Testing Instructions

1. Create and publish a post
2. Write two block comments on the post via editor
3. Write two actual comments on the post via the front end
4. Approve the front end comments if required by your moderation settings
5. Run the following in wp shell, replacing the post ID with the ID created above

wp> get_comments( ['post_id' => 89, 'fields' => 'ids'] );
// Ensure the resulting IDs do not include the block comments
wp> get_comments( ['post_id' => 89, 'fields' => 'ids', 'type' => 'block_comment'] );
// Ensure the resulting IDs include the block comments and not the front end comments

Testing Instructions for Keyboard

N/A

Screenshots or screencast

N/A

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: peterwilsoncc <[email protected]>
Co-authored-by: adamsilverstein <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[adamsilverstein]

Looks good!

[adamsilverstein]

Code looks good, checking to verify this fixes the issue...

[adamsilverstein]

This works well in my testing, thanks @peterwilsoncc!