Skip to content

Give user alert to confirm browser refresh #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hlashbrooke opened this issue Nov 27, 2022 · 2 comments · May be fixed by #2196
Open

Give user alert to confirm browser refresh #81

hlashbrooke opened this issue Nov 27, 2022 · 2 comments · May be fixed by #2196

Comments

@hlashbrooke
Copy link

To prevent accidental page refreshes that will lose the user's data and progress, it would be great to have a basic browser alert that confirms if the user does want to refresh before it actually happens.

@artemiomorales artemiomorales added UI/UX [Type] Enhancement New feature or request Good First Issue Good for newcomers labels Feb 7, 2023
@akansjain
Copy link

Hey @hlashbrooke ,
Please assign this issue to me.

@adamziel
Copy link
Collaborator

adamziel commented Jun 2, 2023

@akansjain there you go!

@tyrann0us tyrann0us marked this as a duplicate of #2192 Apr 22, 2025
bgrgicak added a commit that referenced this issue May 7, 2025
#81)

## Motivation for the change, related issues

Before this PR the `setSiteLanguage` step automatically tried to resolve
the WordPress core translation version, but some combinations of
versions and languages don't have translation packages.

This PR uses the WordPress.org translations API to get the correct
translation URL for the given WordPress version and language.

If a translation package doesn't exist, the step will still fail. 

## Implementation details

Instead of inferring the WordPress version, `setSiteLanguage` now uses
the `api.wordpress.org/translations/core/1.0` endpoint to get the
correct translation URL for the given WordPress version and language.

This approach ensures we return an existing translation URL whenever
possible and moves the WP version resolution to the WordPress.org
translations API.

## Testing Instructions (or ideally a Blueprint)

- CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants